fix: generate unique SSL IDs to prevent certificate conflicts across different hosts #2592
+158
−86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Previously, SSL objects used certificate content to generate IDs (
id.GenID(string(cert))
).When the same certificate was referenced by multiple resources (e.g., ApisixTls and Ingress) with different hostnames, they would generate the same SSL ID, causing conflicts where only one SSL object would be created and this may cause error. So we change the ssl id generate logic.
This ensures each TLS configuration creates a unique SSL object, even when using the same certificate.
And, because CI has been occurring errors, the tcproute test case was also fixed.
Pre-submission checklist: