Skip to content

Conversation

ronething
Copy link
Contributor

@ronething ronething commented Oct 9, 2025

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Previously, SSL objects used certificate content to generate IDs (id.GenID(string(cert))).
When the same certificate was referenced by multiple resources (e.g., ApisixTls and Ingress) with different hostnames, they would generate the same SSL ID, causing conflicts where only one SSL object would be created and this may cause error. So we change the ssl id generate logic.

This ensures each TLS configuration creates a unique SSL object, even when using the same certificate.

And, because CI has been occurring errors, the tcproute test case was also fixed.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
@ronething ronething changed the title fix: change ssl id generate logic. fix: generate unique SSL IDs to prevent certificate conflicts across different hosts Oct 9, 2025
@ronething ronething marked this pull request as ready for review October 9, 2025 10:24
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants