Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions chart/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -3362,6 +3362,11 @@
"description": "Query to use for KEDA autoscaling. Must return a single integer.",
"type": "string",
"default": "SELECT ceil(COUNT(*)::decimal / {{ .Values.config.triggerer.default_capacity }}) FROM trigger"
},
"usePgbouncer": {
"description": "Whether to use PGBouncer to connect to the database or not when it is enabled. This configuration will be ignored if PGBouncer is not enabled.",
"type": "boolean",
"default": false
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1688,6 +1688,10 @@ triggerer:
SELECT ceil(COUNT(*)::decimal / {{ .Values.config.triggerer.default_capacity }})
FROM trigger

# Whether to use PGBouncer to connect to the database or not when it is enabled
# This configuration will be ignored if PGBouncer is not enabled
usePgbouncer: false

# Airflow Dag Processor Config
dagProcessor:
enabled: false
Expand Down
14 changes: 14 additions & 0 deletions helm_tests/airflow_core/test_triggerer.py
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,20 @@ def test_should_use_keda_query(self, query, expected_query):
)
assert expected_query == jmespath.search("spec.triggers[0].metadata.query", docs[0])

def test_mysql_db_backend_keda_default_value(self):
docs = render_chart(
values={
"data": {"metadataConnection": {"protocol": "mysql"}},
"triggerer": {
"enabled": True,
"keda": {"enabled": True},
},
},
show_only=["templates/triggerer/triggerer-kedaautoscaler.yaml"],
)

assert jmespath.search("spec.triggerers[0].metadata.keda.usePgBouncer", docs[0]) is None

def test_mysql_db_backend_keda(self):
docs = render_chart(
values={
Expand Down
2 changes: 1 addition & 1 deletion helm_tests/airflow_core/test_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ def test_should_use_keda_query(self, query, executor, expected_query):
)
assert expected_query == jmespath.search("spec.triggers[0].metadata.query", docs[0])

def test_mysql_db_backend_keda(self):
def test_mysql_db_backend_keda_worker(self):
docs = render_chart(
values={
"data": {"metadataConnection": {"protocol": "mysql"}},
Expand Down