[SOL] Allocate less space on stack for drift sort #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
force-pushed
the
fix-error-msg
branch
2 times, most recently
from
a6fd4cf to
0e666ae
Compare
Lichtso
approved these changes
May 8, 2025
LucasSte
added a commit
to LucasSte/rust
that referenced
this pull request
Aug 21, 2025
LucasSte
added a commit
to LucasSte/rust
that referenced
this pull request
Aug 21, 2025
LucasSte
added a commit
to LucasSte/rust
that referenced
this pull request
Sep 12, 2025
LucasSte
added a commit
to LucasSte/rust
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When building a Solana contract with Rust 1.84.1, we face a stack overflow warning coming from drift sort, Rust's new default sorting algorithm. It allocates 4096 bytes on the stack to avoid heap allocations.
Solution
Allocate only 2048 bytes for SBPFv0.