-
Notifications
You must be signed in to change notification settings - Fork 139
ci: update branch in migrator #3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to avoid conflicts. We merge with main later, and apply the logic.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis PR refines the migrator workflow by standardizing string interpolation and logging, and by overhauling the branch merge procedure to include pulling from the head repo, merging in main, and detecting conflicts. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- The ANSI escape codes for colored logs may not render correctly in GitHub Actions and can clutter output—consider removing them or using the built-in log grouping and annotation features.
- Verify that merging 'origin/main' into the PR branch is the intended workflow; you might want to parameterize the base branch name instead of hardcoding 'main' for broader flexibility.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ys/pymapdl into ci/update-branch-in-migrator
Before merging, can you @RobPasMue review the last commit?? cf85214 Asking @ansys/pyansys-core for another review or look. Pinging @jorgepiloto @klmcadams @moe-ad for awareness. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3973 +/- ##
=======================================
Coverage 88.25% 88.26%
=======================================
Files 187 187
Lines 14935 14935
=======================================
+ Hits 13181 13182 +1
+ Misses 1754 1753 -1 🚀 New features to boost your workflow:
|
Description
Fixing errors highlighted in #3972
Issue linked
Close #3972
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Fix errors in the migrator workflow by standardizing string interpolation, enhancing logging, and updating branch merge logic with conflict detection
CI: