feat: Raise exception on read-only command execution #4619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
hpohekar,
mayankansys,
prmukherj and
seanpearsonuk
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new exception type ReadOnlyActionError to prevent execution of read-only commands and queries in PyFluent. Previously, the system allowed executing read-only commands/queries, which was incorrect behavior.
Key Changes:
- Added
ReadOnlyActionErrorexception class for read-only command/query execution attempts - Implemented checks in command and query
__call__methods to raise the exception when read-only - Added test coverage for the new exception behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ansys/fluent/core/solver/flobject.py | Added ReadOnlyActionError exception class and read-only checks in command/query execution methods |
| tests/test_settings_api.py | Added test_read_only_command_execution test and imported new exception types |
| tests/conftest.py | Added mixing_elbow_case_session fixture to support the new test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Relevant Fluent ADO id - 1354052 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hpohekar
approved these changes
Nov 18, 2025
prmukherj
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Earlier it was possible to execute a read-only command or query.
Change Summary
A new exception-type is raised when user tries to execute a read-only command/query. Note that, attribute access of read-only command/query and its arguments should still work.
Rationale
We already throw a different exception-type from PyFluent when user tries to execute an inactive command/query. Raising of the new exception for read-only command/query has been at the same place.
Impact
This will fix the current incorrect behaviour, a new unittest has been added.