Skip to content

fix: fix Field.data for LegacyGrpcServer #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix Field.data for LegacyGrpcServer #2668

wants to merge 1 commit into from

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Oct 10, 2025 •
edited
Loading

A script using only a LegacyGrpcServer would raise an AttributeError in Field._get_data when trying to create a DPFVectorDouble.
This error type was no longer caught in #2141

@PProfizi PProfizi requested a review from rafacanton October 10, 2025 08:55
@PProfizi PProfizi self-assigned this Oct 10, 2025
@PProfizi PProfizi requested a review from a team as a code owner October 10, 2025 08:55
@PProfizi PProfizi added the bug Something isn't working label Oct 10, 2025
@PProfizi PProfizi linked an issue Oct 10, 2025 that may be closed by this pull request
Regression in 0.13.7 when extracting data from a field. #2279
Open
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

Some tests with 'continue-on-error: true' have failed:

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.36%. Comparing base (8d518f6) to head (2c9ef47).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
+ Coverage   84.26%   84.36%   +0.10%     
==========================================
  Files          92       92              
  Lines       10858    10858              
==========================================
+ Hits         9149     9160      +11     
+ Misses       1709     1698      -11

@PProfizi
Copy link
Contributor Author

Waiting for #2669 to have the configuration of the issue covered in the CI and verify that this fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafacanton rafacanton rafacanton approved these changes

Assignees

@PProfizi PProfizi

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression in 0.13.7 when extracting data from a field.

2 participants

@PProfizi @rafacanton