Skip to content

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jul 4, 2025

Closes part of #2224

@PProfizi PProfizi self-assigned this Jul 4, 2025
@PProfizi PProfizi added the enhancement New feature or request label Jul 4, 2025
@PProfizi PProfizi changed the title feat: return plotter on plot command feat(plotter): return plotter on plot command Jul 4, 2025
@PProfizi PProfizi changed the title feat(plotter): return plotter on plot command feat(plotter): return the plotter instance Jul 4, 2025
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Some tests with 'continue-on-error: true' have failed:

  • PyDPF-Post docstring tests on ubuntu-latest

  • PyDPF-Post docstring tests on windows-latest

    Created by continue-on-error-comment

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.19%. Comparing base (70c5cef) to head (e46f7f4).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
+ Coverage   84.16%   84.19%   +0.02%     
==========================================
  Files          91       91              
  Lines       10597    10597              
==========================================
+ Hits         8919     8922       +3     
+ Misses       1678     1675       -3     

Copy link
Contributor

github-actions bot commented Jul 4, 2025

The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2413. Please allow some time for the documentation to be deployed.

@rafacanton
Copy link
Contributor

@PProfizi Thanks for this! I guess we need a prallel post PR to clean the tests

@PProfizi PProfizi merged commit f0b3727 into master Jul 7, 2025
87 of 89 checks passed
@PProfizi PProfizi deleted the feat/plotter_return_pyvista_plotter branch July 7, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants