MAINT: remove duplicate id safeguarding #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, we'll need a new unstable server image with DMS nuget 021 before we merge this |
|
Linux unstable is good, windows unstable image is still using compressed monikers, for some reason, need to push a new image |
jonahrb
changed the title
RobPasMue
changed the title
…sterComponent everywhere." This reverts commit 664e584.
jonahrb
previously approved these changes
May 18, 2023
RobPasMue
previously approved these changes
May 19, 2023
There was a problem hiding this comment.
Looking great @jonahrb @dastan-ansys ! Thanks for the implementation =)
Let me trigger the workflow to generate new stable images
|
I think that @b-matteo's push to unstable might have crashed this... re-triggering execution just in case |
|
Yep, that's what I thought... For some reason, @b-matteo's push also caused this to stop working |
RobPasMue
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.