-
Notifications
You must be signed in to change notification settings - Fork 22
Feat/enhance parameters #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jonahrb - requesting some major changes before continuing to review. Re-request review once you're finished with them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jonahrb! Some small comments. Merging them and into main :)
Wanted to give more information about the parameterization of primitives. All descriptions of parameterization come from SC. The class structure is based off UGC. I decided not to go with the original approach - as this approach gives much more structured information to the user.
There are some things we could do differently if we want to -
get_u/v_parameterization()a property, or maybe even a static variableExample usage:
@RobPasMue @chris-hawkins-usa let me know if you guys have any input