Skip to content

Conversation

@jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Feb 20, 2023

Wanted to give more information about the parameterization of primitives. All descriptions of parameterization come from SC. The class structure is based off UGC. I decided not to go with the original approach - as this approach gives much more structured information to the user.

There are some things we could do differently if we want to -

  • could make get_u/v_parameterization() a property, or maybe even a static variable

Example usage:

print(sphere.get_u_parameterization())
print(sphere.get_v_parameterization())
print(line.get_parameterization())

Output:
Parameterization(form=ParamForm.PERIODIC, type=ParamType.CIRCULAR, interval=Interval(start=0, end=6.283185307179586))
Parameterization(form=ParamForm.CLOSED, type=ParamType.OTHER, interval=Interval(start=-1.5707963267948966, end=1.5707963267948966))
Parameterization(form=ParamForm.OPEN, type=ParamType.LINEAR, interval=Interval(start=-inf, end=inf))

@RobPasMue @chris-hawkins-usa let me know if you guys have any input

@jonahrb jonahrb requested a review from RobPasMue as a code owner February 20, 2023 16:13
@jonahrb jonahrb linked an issue Feb 20, 2023 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 20, 2023
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jonahrb - requesting some major changes before continuing to review. Re-request review once you're finished with them.

@github-actions github-actions bot added the testing Anything related to tests label Feb 21, 2023
@jonahrb jonahrb requested a review from RobPasMue February 21, 2023 17:22
RobPasMue
RobPasMue previously approved these changes Feb 22, 2023
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jonahrb! Some small comments. Merging them and into main :)

@RobPasMue RobPasMue enabled auto-merge (squash) February 22, 2023 08:52
@RobPasMue RobPasMue self-requested a review February 22, 2023 09:04
@RobPasMue RobPasMue merged commit aeecfae into main Feb 22, 2023
@RobPasMue RobPasMue deleted the feat/enhance-parameters branch February 22, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Parameterization intervals to all primitives

3 participants