Skip to content

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Feb 20, 2023

@RobPasMue I missed a few locations for allowing Real input - this PR addresses some of those that I found

  • Real input for extrude_sketch()
  • Real for Sketch().circle(), ellipse, polygon, gears
    • all input validation for these are already handled in the sketch objects themselves

Didn't write any unit tests for these because it's already handled at lower level, and tests still all pass anyway :)

@jonahrb jonahrb requested a review from RobPasMue as a code owner February 20, 2023 15:11
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 20, 2023
RobPasMue
RobPasMue previously approved these changes Feb 20, 2023
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor comment

@RobPasMue RobPasMue self-requested a review February 20, 2023 16:48
RobPasMue
RobPasMue previously approved these changes Feb 20, 2023
@RobPasMue RobPasMue enabled auto-merge (squash) February 20, 2023 16:49
@jonahrb
Copy link
Contributor Author

jonahrb commented Feb 20, 2023

@RobPasMue pushed new changes for translating bodies :)

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue merged commit f4970e7 into main Feb 20, 2023
@RobPasMue RobPasMue deleted the feat/allow-Real-in-sketching branch February 20, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants