Skip to content

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Feb 14, 2023

Ability to upload a file from client to server and open it

@jonahrb jonahrb requested a review from RobPasMue February 14, 2023 17:51
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 14, 2023
@jonahrb
Copy link
Contributor Author

jonahrb commented Feb 14, 2023

@RobPasMue definitely going to need your input on design choices here, and how/if I can better test this. We don't exactly have a test_modeler.py so I went ahead and put this in test_design.py since it seemed most fitting.

@RobPasMue
Copy link
Member

@RobPasMue definitely going to need your input on design choices here, and how/if I can better test this. We don't exactly have a test_modeler.py so I went ahead and put this in test_design.py since it seemed most fitting.

Let's talk offline about this and summarize here on GH our decision

@RobPasMue RobPasMue changed the title Feat/upload file Implementing file upload Feb 17, 2023
@jonahrb
Copy link
Contributor Author

jonahrb commented May 16, 2023

As of now, this feature should be done and should pass when the new unstable images get published. We need to figure out how we want to test this though. For now I can just create create something, download the file, then upload the file.

@RobPasMue RobPasMue changed the title Upload and Open a File FEAT: upload and open a file May 18, 2023
@RobPasMue RobPasMue requested a review from a team as a code owner May 18, 2023 07:45
@jonahrb jonahrb requested a review from dastan-ansys May 18, 2023 18:54
dastan-ansys
dastan-ansys previously approved these changes May 22, 2023
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @jonahrb

@RobPasMue RobPasMue enabled auto-merge (squash) May 24, 2023 14:36
@RobPasMue RobPasMue merged commit 7e07357 into main May 24, 2023
@RobPasMue RobPasMue deleted the feat/upload-file branch May 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capability to InsertDocument into a design

3 participants