Skip to content

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Sep 12, 2025

Description

We made build changes for 261 to include dotnet 8

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Sep 12, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Sep 12, 2025
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.81%. Comparing base (e778a10) to head (1151354).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2226      +/-   ##
==========================================
- Coverage   94.83%   94.81%   -0.02%     
==========================================
  Files         142      142              
  Lines       10583    10585       +2     
==========================================
  Hits        10036    10036              
- Misses        547      549       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanJWard RyanJWard marked this pull request as ready for review September 15, 2025 15:06
@RyanJWard RyanJWard requested a review from a team as a code owner September 15, 2025 15:06
b-matteo
b-matteo previously approved these changes Sep 15, 2025
Copy link
Contributor

@b-matteo b-matteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanJWard RyanJWard requested a review from RobPasMue September 16, 2025 11:29
@RyanJWard RyanJWard requested a review from RobPasMue September 16, 2025 14:05
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RyanJWard RyanJWard merged commit d3b86b3 into main Sep 16, 2025
52 checks passed
@RyanJWard RyanJWard deleted the feat/update_linux_launcher_261 branch September 16, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants