Skip to content

Conversation

jacobrkerstetter
Copy link
Contributor

Description

  • initial client side implementation of NURBS surfaces
  • used for PoC for 2 workflows

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Sep 10, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner September 10, 2025 12:14
@github-actions github-actions bot added testing Anything related to tests enhancement New features or code improvements labels Sep 10, 2025
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 92.80576% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.83%. Comparing base (5ecc001) to head (936775d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/shapes/surfaces/nurbs.py 92.80% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
- Coverage   94.85%   94.83%   -0.03%     
==========================================
  Files         141      142       +1     
  Lines       10444    10583     +139     
==========================================
+ Hits         9907    10036     +129     
- Misses        537      547      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jacobrkerstetter!

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) September 16, 2025 12:47
@jacobrkerstetter jacobrkerstetter merged commit e778a10 into main Sep 16, 2025
60 of 62 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/nurbs_surface_impl branch September 16, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants