-
Notifications
You must be signed in to change notification settings - Fork 20
fix: add skip_if_discovery method #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add skip_if_discovery method skip export tests for unsupported formats in Discovery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new skip_if_discovery
utility function to skip export tests when running on Discovery backend, as these formats are not supported on that platform.
- Added
skip_if_discovery
function in conftest.py to check for Discovery backend types - Applied skip condition to several export test functions that use unsupported formats on Discovery
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/integration/conftest.py | Implements the new skip_if_discovery utility function |
tests/integration/test_design_export.py | Applies the skip condition to export tests for scdocx and fmd formats |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2202 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 141 141
Lines 10404 10404
=======================================
Hits 9865 9865
Misses 539 539 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -457,6 +464,9 @@ def test_import_export_open_file_design( | |||
expected_bodies, | |||
): | |||
"""Test importing, exporting, and opening a file in a new design.""" | |||
skip_if_discovery( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both paradolid txt and SCDOCX not accepted in Disco? I would just skip the one that gives problems and adapt the message accordingly
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Add skip_if_discovery method
skip export tests for unsupported formats in Discovery
Description
Please provide a brief description of the changes made in this pull request.
Skip unsupported formats when testing against Discovery
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
#2201
Checklist
feat: extrude circle to cylinder
)