Skip to content

Conversation

b-matteo
Copy link
Contributor

@b-matteo b-matteo commented Aug 29, 2025

Add skip_if_discovery method
skip export tests for unsupported formats in Discovery

Description

Please provide a brief description of the changes made in this pull request.
Skip unsupported formats when testing against Discovery

Issue linked

Please mention the issue number or describe the problem this pull request addresses.
#2201

Checklist

  • I have tested my changes locally.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Add skip_if_discovery method
skip export tests for unsupported formats in Discovery
@b-matteo b-matteo requested review from RobPasMue and Copilot August 29, 2025 15:12
@b-matteo b-matteo self-assigned this Aug 29, 2025
@b-matteo b-matteo requested a review from a team as a code owner August 29, 2025 15:12
@b-matteo b-matteo added the bug Something isn't working label Aug 29, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new skip_if_discovery utility function to skip export tests when running on Discovery backend, as these formats are not supported on that platform.

  • Added skip_if_discovery function in conftest.py to check for Discovery backend types
  • Applied skip condition to several export test functions that use unsupported formats on Discovery

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/integration/conftest.py Implements the new skip_if_discovery utility function
tests/integration/test_design_export.py Applies the skip condition to export tests for scdocx and fmd formats

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.81%. Comparing base (48e8ca1) to head (956305e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2202   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files         141      141           
  Lines       10404    10404           
=======================================
  Hits         9865     9865           
  Misses        539      539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -457,6 +464,9 @@ def test_import_export_open_file_design(
expected_bodies,
):
"""Test importing, exporting, and opening a file in a new design."""
skip_if_discovery(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both paradolid txt and SCDOCX not accepted in Disco? I would just skip the one that gives problems and adapt the message accordingly

@RobPasMue RobPasMue merged commit 1688b2e into main Sep 2, 2025
50 of 52 checks passed
@RobPasMue RobPasMue deleted the fix/2201_discovery_export_fails branch September 2, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants