Skip to content

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Aug 27, 2025

Description

Add save facet test for .dsco file

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Aug 27, 2025
@RyanJWard RyanJWard requested a review from a team as a code owner August 27, 2025 11:37
@RyanJWard RyanJWard added the testing Anything related to tests label Aug 27, 2025
@github-actions github-actions bot removed the testing Anything related to tests label Aug 27, 2025
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.66%. Comparing base (bbcee33) to head (a9ce815).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2199   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         141      141           
  Lines       10404    10404           
=======================================
  Hits         9849     9849           
  Misses        555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RobPasMue
RobPasMue previously approved these changes Aug 27, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the testing Anything related to tests label Aug 27, 2025
@RobPasMue RobPasMue merged commit ae41607 into main Aug 27, 2025
51 of 54 checks passed
@RobPasMue RobPasMue deleted the test/new_test_promote_passing_tests branch August 27, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants