Skip to content

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Aug 21, 2025

Description

Mathematical approximations lead to potential negative values when performing sqrt. Allowing rounding using abs.

Issue linked

Closes #2074

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 21, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner August 21, 2025 15:02
@RobPasMue RobPasMue linked an issue Aug 21, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Aug 21, 2025
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.63%. Comparing base (207ed74) to head (6a67deb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2190      +/-   ##
==========================================
+ Coverage   94.51%   94.63%   +0.12%     
==========================================
  Files         141      141              
  Lines       10404    10404              
==========================================
+ Hits         9833     9846      +13     
+ Misses        571      558      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit e15f9ba into main Aug 21, 2025
82 of 87 checks passed
@RobPasMue RobPasMue deleted the fix/approximations-arc-start-end-radius branch August 21, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arc_from_start_end_and_radius
2 participants