Skip to content

Conversation

RobPasMue
Copy link
Member

Description

Users have a hard time using the tools/commands. They end up instantiating objects of their own when they shouldn't. They should be using directly from the modeler object. We will know throw errors whenever this happens.

Issue linked

Closes #2184

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 21, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner August 21, 2025 09:45
@github-actions github-actions bot added the bug Something isn't working label Aug 21, 2025
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.63%. Comparing base (24eeafa) to head (8e288b8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2188      +/-   ##
==========================================
+ Coverage   94.59%   94.63%   +0.04%     
==========================================
  Files         141      141              
  Lines       10392    10404      +12     
==========================================
+ Hits         9830     9846      +16     
+ Misses        562      558       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 207ed74 into main Aug 21, 2025
48 of 50 checks passed
@RobPasMue RobPasMue deleted the fix/prevent-tool-instantiation branch August 21, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in ... Repair Tools
2 participants