Skip to content

Conversation

jacobrkerstetter
Copy link
Contributor

Description

  • Needed for material designer workflows
  • Added additional method to construct body via sweep with additional guide curve parameter

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Aug 18, 2025
@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Aug 18, 2025
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review August 18, 2025 15:47
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner August 18, 2025 15:47
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.63%. Comparing base (33c5744) to head (73ac5db).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v0/conversions.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
- Coverage   94.70%   94.63%   -0.07%     
==========================================
  Files         141      141              
  Lines       10327    10361      +34     
==========================================
+ Hits         9780     9805      +25     
- Misses        547      556       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the maintenance Package and maintenance related label Aug 19, 2025
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) August 19, 2025 13:17
RobPasMue
RobPasMue previously approved these changes Aug 19, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) August 19, 2025 19:06
@jacobrkerstetter jacobrkerstetter merged commit 32797ba into main Aug 19, 2025
87 of 88 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/body_sweep_with_guide_impl branch August 19, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants