Skip to content

Conversation

RobPasMue
Copy link
Member

Description

Clarify logic in min_distance_between_objects gRPC call

Issue linked

#2156

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue requested a review from a team as a code owner August 12, 2025 07:33
@RobPasMue RobPasMue self-assigned this Aug 12, 2025
@RobPasMue RobPasMue linked an issue Aug 12, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Aug 12, 2025
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.72%. Comparing base (916da49) to head (9dd798a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2166   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         141      141           
  Lines       10319    10319           
=======================================
  Hits         9775     9775           
  Misses        544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 118e273 into main Aug 12, 2025
86 of 88 checks passed
@RobPasMue RobPasMue deleted the fix/clarify-logic branch August 12, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"GeometryExitedError: Geometry service connection terminated: "
2 participants