Skip to content

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Aug 1, 2025

Description

  • new method to set multiple export ids at once
  • expanded test_open_file to utilize this feature

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

- expanded test_open_file to utilize this feature
@jacobrkerstetter jacobrkerstetter self-assigned this Aug 1, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 1, 2025
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review August 5, 2025 20:05
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner August 5, 2025 20:05
@github-actions github-actions bot added the maintenance Package and maintenance related label Aug 5, 2025
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.88%. Comparing base (8329435) to head (072ff99).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2148   +/-   ##
=======================================
  Coverage   94.87%   94.88%           
=======================================
  Files         141      141           
  Lines       10307    10319   +12     
=======================================
+ Hits         9779     9791   +12     
  Misses        528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jonahrb jonahrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) August 6, 2025 13:59
@jacobrkerstetter jacobrkerstetter merged commit f6197b8 into main Aug 6, 2025
51 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/set_multiple_export_ids branch August 6, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants