Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/2118.added.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Surface body unit test fix
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,7 @@ def serialize_body(body):
},
"master_id": body.master_id,
"parent_id": body.parent_id,
"is_surface": body.is_surface,
}

def serialize_entity_identifier(entity):
Expand Down
1 change: 1 addition & 0 deletions src/ansys/geometry/core/tools/problem_areas.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ def serialize_body(body):
},
"master_id": body.master_id,
"parent_id": body.parent_id,
"is_surface": body.is_surface,
}

def serialize_entity_identifier(entity):
Expand Down
10 changes: 4 additions & 6 deletions tests/integration/test_repair_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -403,10 +403,9 @@ def test_find_and_fix_missing_faces(modeler: Modeler):
for face in missing_faces:
face.fix()

# TODO : Add surface body check from backend. Issue is being tracked in #2031.
# assert not design.bodies[0].is_surface
# for comp in design.components:
# assert not comp.bodies[0].is_surface
assert not design.bodies[0].is_surface
for comp in design.components:
assert not comp.bodies[0].is_surface


def test_find_and_fix_missing_faces_angle_distance(modeler: Modeler):
Expand Down Expand Up @@ -458,8 +457,7 @@ def test_find_and_stitch_and_missing_faces(modeler: Modeler):
for i in stitch_faces:
i.fix()
assert len(design.bodies) == 1
# TODO : Add surface body check from backend. Issue is being tracked in #2031.
# assert design.bodies[0].is_surface
assert design.bodies[0].is_surface
missing_faces = modeler.repair_tools.find_missing_faces(design.bodies)
for face in missing_faces:
face.fix()
Expand Down
Loading