Skip to content

feat: nurbs sketching and surface support #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jul 16, 2025
Merged

feat: nurbs sketching and surface support #2104

merged 33 commits into from
Jul 16, 2025

Conversation

jacobrkerstetter
Copy link
Contributor

Description

Provide ability to sketch 2D NURBS curves and transform them into surface bodies for Workflow 12.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Jul 11, 2025
@github-actions github-actions bot added testing Anything related to tests enhancement New features or code improvements labels Jul 11, 2025
@RobPasMue RobPasMue linked an issue Jul 14, 2025 that may be closed by this pull request
Creating smooth interpolation curves #2091
Closed
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review July 15, 2025 12:36
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner July 15, 2025 12:36
@github-actions github-actions bot added the maintenance Package and maintenance related label Jul 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.10989% with 9 lines in your changes missing coverage. Please review.

Project coverage is 94.19%. Comparing base (ac2c39f) to head (80e7c0e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/sketch/nurbs.py 91.54% 6 Missing ⚠️
...ys/geometry/core/_grpc/_services/v0/conversions.py 84.61% 2 Missing ⚠️
src/ansys/geometry/core/sketch/edge.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2104      +/-   ##
==========================================
- Coverage   94.21%   94.19%   -0.02%     
==========================================
  Files         138      139       +1     
  Lines       10156    10242      +86     
==========================================
+ Hits         9568     9647      +79     
- Misses        588      595       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the maintenance Package and maintenance related label Jul 15, 2025
RobPasMue
RobPasMue reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments - overall is looking good!

RobPasMue
RobPasMue previously approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) July 16, 2025 14:00
@jacobrkerstetter jacobrkerstetter merged commit 2b95f88 into main Jul 16, 2025
44 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/nurbs_sketching branch July 16, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jacobrkerstetter jacobrkerstetter

Labels
enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating smooth interpolation curves
3 participants
@jacobrkerstetter @RobPasMue @pyansys-ci-bot