Skip to content

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Jul 9, 2025

Description

Logo removal should be fixed and working on Linux

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Jul 9, 2025
@RyanJWard RyanJWard added enhancement New features or code improvements testing Anything related to tests labels Jul 9, 2025
@github-actions github-actions bot removed the testing Anything related to tests label Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (f82160d) to head (075ad84).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2098      +/-   ##
==========================================
- Coverage   93.68%   93.64%   -0.04%     
==========================================
  Files         138      138              
  Lines       10156    10156              
==========================================
- Hits         9515     9511       -4     
- Misses        641      645       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanJWard RyanJWard marked this pull request as ready for review July 14, 2025 13:14
@RyanJWard RyanJWard requested a review from a team as a code owner July 14, 2025 13:14
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue merged commit 15e0d51 into main Jul 14, 2025
72 of 80 checks passed
@RobPasMue RobPasMue deleted the test/allow_logo_removal_linux branch July 14, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants