Skip to content

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Jun 25, 2025

Description

  • added functionality for components to be sent to move_translate
  • tested with a box

Issue linked

#2067

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter requested a review from jonahrb June 25, 2025 13:15
@jacobrkerstetter jacobrkerstetter self-assigned this Jun 25, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner June 25, 2025 13:15
@github-actions github-actions bot added the enhancement New features or code improvements label Jun 25, 2025
RobPasMue
RobPasMue previously approved these changes Jun 25, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha.. sounds good! LGTM

@jacobrkerstetter jacobrkerstetter marked this pull request as draft June 25, 2025 13:30
@RobPasMue
Copy link
Member

RobPasMue commented Jun 25, 2025

This might need some server side fix. Which means that we should also warn that components can only be translated starting on 26R1 I guess - unless we plan on adding this feature to a SP for 25R2.

@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review June 25, 2025 13:55
@jacobrkerstetter jacobrkerstetter changed the title feat: enhanced move_translate to support components feat: add components to NS Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.83%. Comparing base (72c56fa) to head (63a70b1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/selection.py 78.57% 3 Missing ⚠️
src/ansys/geometry/core/misc/auxiliary.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2068      +/-   ##
==========================================
- Coverage   92.86%   92.83%   -0.03%     
==========================================
  Files         137      137              
  Lines        9877     9894      +17     
==========================================
+ Hits         9172     9185      +13     
- Misses        705      709       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter marked this pull request as draft June 25, 2025 14:52
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review July 1, 2025 10:18
@jacobrkerstetter jacobrkerstetter linked an issue Jul 1, 2025 that may be closed by this pull request
@github-actions github-actions bot added the maintenance Package and maintenance related label Jul 2, 2025
@github-actions github-actions bot removed the maintenance Package and maintenance related label Jul 2, 2025
Copy link
Contributor

@jonahrb jonahrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - re approving for Roberto

@jonahrb jonahrb merged commit 443a380 into main Jul 2, 2025
45 checks passed
@jonahrb jonahrb deleted the feat/move_translate_components branch July 2, 2025 13:45
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonahrb and @jacobrkerstetter for approving and implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Components to NamedSelection
4 participants