-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add components to NS #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tested with a box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha.. sounds good! LGTM
This might need some server side fix. Which means that we should also warn that components can only be translated starting on 26R1 I guess - unless we plan on adding this feature to a SP for 25R2. |
reverted changes to move_translate
…nsys/pyansys-geometry into feat/move_translate_components
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
- Coverage 92.86% 92.83% -0.03%
==========================================
Files 137 137
Lines 9877 9894 +17
==========================================
+ Hits 9172 9185 +13
- Misses 705 709 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added a test to fetch components from NS
…nsys/pyansys-geometry into feat/move_translate_components
…nsys/pyansys-geometry into feat/move_translate_components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - re approving for Roberto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jonahrb and @jacobrkerstetter for approving and implementing this!
Description
Issue linked
#2067
Checklist
feat: extrude circle to cylinder
)