Skip to content

Conversation

RobPasMue
Copy link
Member

Description

Avoid the server side error when an empty Named Selection attempts to be created.

Issue linked

Closes #2059

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jun 23, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner June 23, 2025 09:17
@github-actions github-actions bot added the bug Something isn't working label Jun 23, 2025
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (33a3df2) to head (4d0d3ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2063   +/-   ##
=======================================
  Coverage   92.60%   92.61%           
=======================================
  Files         136      136           
  Lines        9810     9812    +2     
=======================================
+ Hits         9085     9087    +2     
  Misses        725      725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit ad97ab1 into main Jun 23, 2025
44 checks passed
@RobPasMue RobPasMue deleted the fix/disable-empty-ns-creation branch June 23, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Create Empty Named Selection
2 participants