Skip to content

Conversation

syscordan
Copy link
Contributor

@syscordan syscordan commented Jun 20, 2025

Description

Expanding test coverage for designer/selection.py, designer/part.py, math\bbox.py, math\matrix.py, math\vector.py

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

…math\bbox.py, math\matrix.py, math\vector.py
@syscordan syscordan self-assigned this Jun 20, 2025
@syscordan syscordan requested a review from a team as a code owner June 20, 2025 18:34
@syscordan syscordan added the testing Anything related to tests label Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (38ee044) to head (010dceb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2061      +/-   ##
==========================================
+ Coverage   92.31%   92.60%   +0.29%     
==========================================
  Files         136      136              
  Lines        9810     9810              
==========================================
+ Hits         9056     9085      +29     
+ Misses        754      725      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@RyanJWard RyanJWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Thanks @syscordan

@RobPasMue RobPasMue merged commit 302325f into main Jun 20, 2025
45 checks passed
@RobPasMue RobPasMue deleted the test/syscordan_designer_math_coverage branch June 20, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants