Skip to content

Conversation

RobPasMue
Copy link
Member

Description

export_glb requires that the actor is a single Polydata. Multiblock's are not handled properly by PyVista's export_gltf function.

Issue linked

Closes #2030

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jun 9, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner June 9, 2025 11:12
@github-actions github-actions bot added the bug Something isn't working label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (b86542b) to head (cffe475).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   90.45%   90.50%   +0.05%     
==========================================
  Files         136      136              
  Lines        9782     9787       +5     
==========================================
+ Hits         8848     8858      +10     
+ Misses        934      929       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 47d23d2 into main Jun 9, 2025
44 checks passed
@RobPasMue RobPasMue deleted the fix/export-glb branch June 9, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLB file exported appears to be incorrect
2 participants