feat: update with delta #1922
Merged
feat: update with delta #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Roberto Pastor Muela <[email protected]>
9 tasks
…nsys-geometry into feat/update-with-delta
RobPasMue
previously approved these changes
Jul 8, 2025
RobPasMue
approved these changes
Jul 8, 2025
RobPasMue
requested changes
Jul 8, 2025
…nsys-geometry into feat/update-with-delta
|
@RobPasMue, you can just approve, switch the true flag, and merge |
RobPasMue
reviewed
Jul 9, 2025
RobPasMue
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
** This Pr introduces a new method to update design object using new trackers coming from API Server. Currently we are trying to keep the synchronization between client and server by updating whole design document after each operation that can possibly cause a change on the backend which is an expensive effort. Recently developed trackers are allowing us to get the only delta from each geometry manipulation operation and the method in this PR updates the design recursively using the information coming from tracker.
It is currently hidden behind a feature flag, for extensive testing and further improvements. **
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)