Skip to content

Conversation

@RobPasMue
Copy link
Member

Description

Switching to Ruff

Issue linked

Closes #1272

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jun 20, 2024
@RobPasMue RobPasMue requested review from a team and PipKat as code owners June 20, 2024 10:38
@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests enhancement New features or code improvements labels Jun 20, 2024
@codecov
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 86.89655% with 19 lines in your changes missing coverage. Please review.

Project coverage is 92.07%. Comparing base (b58c81a) to head (52c72fe).

Files Patch % Lines
...ansys/geometry/core/connection/product_instance.py 61.11% 7 Missing ⚠️
src/ansys/geometry/core/connection/launcher.py 78.57% 3 Missing ⚠️
src/ansys/geometry/core/designer/body.py 94.73% 2 Missing ⚠️
src/ansys/geometry/core/modeler.py 87.50% 2 Missing ⚠️
src/ansys/geometry/core/shapes/surfaces/torus.py 60.00% 2 Missing ⚠️
src/ansys/geometry/core/connection/client.py 83.33% 1 Missing ⚠️
src/ansys/geometry/core/misc/checks.py 50.00% 1 Missing ⚠️
src/ansys/geometry/core/plotting/plotter.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
- Coverage   92.09%   92.07%   -0.02%     
==========================================
  Files          85       85              
  Lines        6613     6598      -15     
==========================================
- Hits         6090     6075      -15     
  Misses        523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to using ruff as linter

4 participants