Skip to content

Conversation

@RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Jun 14, 2024

Description

Providing a way to control the client logs from the launcher methods

Issue linked

Closes #1220

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Jun 14, 2024
@codecov
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.07%. Comparing base (98caeee) to head (004590c).

Files Patch % Lines
...ansys/geometry/core/connection/product_instance.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1260   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          85       85           
  Lines        6572     6574    +2     
=======================================
+ Hits         6051     6053    +2     
  Misses        521      521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review June 14, 2024 08:49
@RobPasMue RobPasMue requested a review from a team as a code owner June 14, 2024 08:50
@RobPasMue RobPasMue self-assigned this Jun 14, 2024
@RobPasMue RobPasMue merged commit 9b67df7 into main Jun 14, 2024
@RobPasMue RobPasMue deleted the feat/launcher_method_logs branch June 14, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow easy-setting of client log levels from launcher functions

3 participants