Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jun 11, 2024

Description

This should fix the plotting issues in the examples, there was a small bug in ansys-tools-visualization-interface that caused the clipping issues in particular. I've patch released the fix.

The CI should be fine after the patch release of ansys-tools-visualization-interface is uploaded to PyPI.

Issue linked

Closes #1249

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the bug Something isn't working label Jun 11, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Jun 11, 2024
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review June 11, 2024 09:05
@AlejandroFernandezLuces AlejandroFernandezLuces requested a review from a team as a code owner June 11, 2024 09:05
@RobPasMue RobPasMue enabled auto-merge (squash) June 11, 2024 10:10
@codecov
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.05%. Comparing base (9491fd0) to head (8a2c7c9).

Files Patch % Lines
src/ansys/geometry/core/plotting/plotter.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   92.06%   92.05%   -0.02%     
==========================================
  Files          85       85              
  Lines        6555     6557       +2     
==========================================
+ Hits         6035     6036       +1     
- Misses        520      521       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 8ccf301 into main Jun 11, 2024
@RobPasMue RobPasMue deleted the fix/show-method-bug branch June 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird issue when requesting body plot

4 participants