Skip to content

Conversation

@RobPasMue
Copy link
Member

Description

Given a sketch, an axis and an origin, we compute the distance between the origin and the sketch plane origin, and revolve the sketch.

Issue linked

Closes #1228

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jun 7, 2024
@github-actions github-actions bot added the enhancement New features or code improvements label Jun 7, 2024
@codecov
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (8ccf301) to head (9062614).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
+ Coverage   92.05%   92.07%   +0.01%     
==========================================
  Files          85       85              
  Lines        6557     6572      +15     
==========================================
+ Hits         6036     6051      +15     
  Misses        521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review June 11, 2024 06:54
@RobPasMue RobPasMue requested a review from a team as a code owner June 11, 2024 06:54
@github-actions github-actions bot added the maintenance Package and maintenance related label Jun 11, 2024
@RobPasMue
Copy link
Member Author

@PipKat I added an example - could you give it a quick review whenever you get the chance?

@RobPasMue RobPasMue merged commit 5a36a07 into main Jun 12, 2024
@RobPasMue RobPasMue deleted the feat/revolve-sketch branch June 12, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a revolve_sketch API given an axis and an angle

3 participants