Skip to content

Conversation

@RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Jun 6, 2024

Description

Improving message description

Issue linked

No issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the maintenance Package and maintenance related label Jun 6, 2024
@RobPasMue RobPasMue marked this pull request as ready for review June 6, 2024 10:32
@RobPasMue RobPasMue requested a review from a team as a code owner June 6, 2024 10:32
@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (0da0d3b) to head (7cb797c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          85       85           
  Lines        6555     6555           
=======================================
  Hits         6043     6043           
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MaxJPRey
MaxJPRey previously approved these changes Jun 6, 2024
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The json Payload format is quite readable. Maintenance should be "easy".

@RobPasMue
Copy link
Member Author

It is yeah - and it renders quite nicely

image

@RobPasMue RobPasMue merged commit 95bc043 into main Jun 6, 2024
@RobPasMue RobPasMue deleted the maint/failing-notifications branch June 6, 2024 12:46
@RobPasMue RobPasMue self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants