Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented May 29, 2024

Description

Fixes the interactive documentation after the integration of ansys-tools-visualization-interface.

Issue linked

Closes #1225

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added maintenance Package and maintenance related bug Something isn't working labels May 29, 2024
@RobPasMue
Copy link
Member

If you need to test deploying feel free to modify the workflow file for doc upload to dev. This one is a valid exception

@codecov
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (c68dc15) to head (fed9d5a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1226   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          85       85           
  Lines        6554     6554           
=======================================
  Hits         6042     6042           
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlejandroFernandezLuces
Copy link
Contributor Author

AlejandroFernandezLuces commented May 29, 2024

If you need to test deploying feel free to modify the workflow file for doc upload to dev. This one is a valid exception

The issue was that it wasn't getting the right jupyter backend in the visualizer library. After fixing that, the generated documentation in the workflows has the interactive documentation working fine. I think this should be good to go, no issues should appear after deployment.

@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review May 29, 2024 10:51
@AlejandroFernandezLuces AlejandroFernandezLuces requested a review from a team as a code owner May 29, 2024 10:51
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobPasMue RobPasMue merged commit 2722049 into main May 29, 2024
@RobPasMue RobPasMue deleted the fix/interactive-documentation branch May 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic graphs broken due to ansys-tools-visualization-interface

3 participants