Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Collaborator

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jun 12, 2024

Overview

Some variables were named object and filter. These are built in variables in Python, so better rename them as soon as possible to avoid issues downstream.

This might break some things in pyansys-geometry, and pyprime, so after this PR is released, fixes will be done in those packages.

@github-actions github-actions bot added testing Anything related to testing bug Something isn't working labels Jun 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.70%. Comparing base (45c04f6) to head (5942e84).

Files Patch % Lines
...isualization_interface/backends/pyvista/pyvista.py 69.23% 4 Missing ⚠️
...on_interface/backends/pyvista/pyvista_interface.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   59.70%   59.70%           
=======================================
  Files          21       21           
  Lines         675      675           
=======================================
  Hits          403      403           
  Misses        272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, much better! Thanks @AlejandroFernandezLuces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants