Docker Agenda/Task list

[gundalow]

Docker Working Group

How to help

• Firstly, click the Subscribe button on the right hand side so you will see update.

• Ansible used GitHub labels to categorize Issues and PRs, therefore everything Docker related has /label/docker

• Reviewing Docker PRs is very useful

  • Actually using and testing the PRs is one of the best types of feedback we can get. Add a comment saying what you tested and how it worked: example of good testing feedback

• Adding and extending the integration tests

• What else?

How to speak to us

• Feel free to add comments on this issue
• Join us in #ansible-devel on Libera - Ansible IRC channels

[felixfontein]

I've compiled a list of PRs which aren't from team docker contributors (i.e. all except ansible/ansible#49235 and ansible/ansible#48574). Most of them look/are dead, except two docker inventory scripts.

docker_container

Both of them look dead. The first one isn't urgend anymore (since docker has been deprecated for a while and docker_container around for a while), but the PR seems to have problems; there are review comments from @chouseknecht which have never been incorporated. I guess closing it is fine, as ansible/ansible#19103 still reminds of it. The second is about adding --cpu support. The main problem with it is that the interface isn't so great. It would be nice to have an easy way to specify CPU usage which works with different docker-py / docker API versions. This is tracked in ansible/ansible#34320, and there's a related issue ansible/ansible#49008 for --cpu-rt-runtime.

• Fixes #19103 - Set Volumes field only for anonymous volumes ansible#19105 [dead]
• Added nano_cpus parameter in the docker_container.py file. ansible#38063 [essentially dead, redesign required]

docker_image

There is one PR about adding a network parameter, which looks good; it is missing some backwards compatibility stuff, and a changelog entry. If the author continues to not reply, I suggest we close this and recreate it. Anyone interested in handling this one?

• docker_image: add network parameter ansible#45127 [probably dead] (revived as docker_image: add network parameter ansible#50313)

docker_network

There are two PRs for adding two features (attachable and scope), both have conflicts and seem dead, but it should be simple to create a new PR adding both features. @DBendit are you interested in working on this?

• Add attachable parameter for Docker overlay networks ansible#35288 [probably dead]
• Add scope parameter for docker networks ansible#45552 [probably dead]

docker_service

The docker module with the most amount of issues... There's one PR fixing something, but it has conflicts and might be dead. Is anyone interested working on this PR and/or the docker_service module in general? There's a lot to do here.

• docker_service: Fix remove_orphans ansible#31305 [maybe dead] (has been replaced by fix remove_orphans using APIs exposed via AnsibleDockerClient ansible#54316)

docker connection plugin

There are two PRs for the docker connection plugin which seem to be dead. The first one is very old, and the author stated that he won't work on it anymore (i.e. definitely dead). It will require some work to rebase this, maybe it's easier to rewrite it. The second one is rather new, but the author never responded after the initial two commits. (It was created during a hackathon, @pilou- knows more.) From the looks of it, it's probably also dead. Is anyone interested in working on the connection plugin?

• Enable docker connector command override. ansible#16198 [dead]
• Add support for setting cwd in docker connection plugin ansible#46547 [probably dead]

inventory scripts

There are three inventory script related PRs. Two add a new inventory script, the third improves an existing one. AFAIK inventory scripts are dead (there is a new plugin category for this), but since I've never used one I don't know much about this. What shall we do about them?

• docker-machine: contribute docker-machine inventory ansible#23149 [dead]
• swarm: added dynamic docker swarm nodes inventory ansible#42667 [alive]
• service/stack for swarm: Docker inventory service/stack groups for docker swarm ansible#48021 [alive] (merged)

@gundalow feel free to close the dead PRs :) For the ones where I only asked a few days ago, maybe we should wait a few more days before closing them?

[DBendit]

@felixfontein Yeah, I can take those two issues. I've also got personal to-dos to consolidate that Python boolean handling from ansible/ansible#48105 into docker_common.py and to generally expand the docker_network integ tests.

[gundalow]

@DBendit Thanks for offering to take a look at some of this. Which two issues are you referring to?

[DBendit]

@gundalow The two that @felixfontein specifically asked me about, ansible/ansible#35288 and ansible/ansible#45552

[felixfontein]

@akshay196 @danihodovic @dariko @DBendit @jwitko @kassiansun @tbouvet

As mentioned above, we currently have a "problem" with docker_service. Nobody from us seems to be interested in it, and there seem to be several active users which have problems (19081, 19371, 20458, 21504, 22358, 23607, 25943, 26937, 28768, 29498, 29513, 29527, 29532, 30548, 31924, 33731, 33960, 37059, 37471, 42506, 47978) which nobody tried to fix for quite some time (except ansible/ansible#31305, which looks inactive). Is anyone of you interested on working on this?

If not, we should try to look for people interested in the module. I guess the easiest way is to post an "advertisement" in each of these issues, and hope that someone there has interest in improving the situation (or at least working on a specific fix). What do you think about the following text?

Thank you for your interest in the docker_service module. Unfortunately, it is currently essentially unmaintained. If you are interested in maintaining it, or working on this (or other) bugs, please feel free to write that here and start working on it!