Skip to content

Add Duration.JulianYear #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 12, 2021
Merged

Conversation

ebfortin
Copy link
Contributor

Julian Year are used in astronomy and cosmology as a constant year length.

Julian Year are used in astronomy and cosmology as a constant year length.
Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things

@ebfortin ebfortin requested a review from angularsen October 30, 2021 19:24
net47 is defacto supported through netstandard2.0.
Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing to revert, then this should be ready to go.

@angularsen angularsen changed the base branch from master to release/v5 November 1, 2021 20:06
@angularsen angularsen changed the base branch from release/v5 to master November 1, 2021 20:07
@ebfortin ebfortin requested a review from angularsen November 3, 2021 00:57
@angularsen angularsen changed the title ADD: Support for Julian Years in Duration unit. Add Duration.JulianYear Nov 12, 2021
@angularsen angularsen merged commit 24e8e28 into angularsen:master Nov 12, 2021
@angularsen
Copy link
Owner

@angularsen
Copy link
Owner

Sorry for the delay. Nuget 4.103.0 is on the way.

@ebfortin ebfortin mentioned this pull request Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants