Skip to content

Support for Julian year #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebfortin opened this issue Oct 11, 2021 · 5 comments
Closed

Support for Julian year #975

ebfortin opened this issue Oct 11, 2021 · 5 comments

Comments

@ebfortin
Copy link
Contributor

ebfortin commented Oct 11, 2021

In Astronomy a year is exactly 365.25 days and is called a Julian year. It is used everywhere years are needed. I propose to add this to the Duration unit. Ref https://en.m.wikipedia.org/wiki/Julian_year_(astronomy)#:~:text=In%20astronomy%2C%20a%20Julian%20year,86400%20SI%20seconds%20each.

If agreed I'll add it to the code and create a PR.

EDIT: The 86400 seconds statement was not true.

@angularsen
Copy link
Owner

Sounds good to me 👍

@ebfortin
Copy link
Contributor Author

I have a problem building UnitsNet. Apparently the .NET Framework Devpacks are not available anymore from MS. And I can't find it anywhere. However UnitsNet build for the .NET Framework 4.0 still. Any way to resolve that?

@angularsen
Copy link
Owner

You should find them here under .NET Framework:
https://dotnet.microsoft.com/download/visual-studio-sdks

If you need a workaround, you could temporarily edit all .csproj files:
<TargetFrameworks>netstandard2.0;net40;net47</TargetFrameworks> to <TargetFramework>netstandard2.0</TargetFramework> (note: singular name, not plural).

@ebfortin
Copy link
Contributor Author

ebfortin commented Oct 24, 2021

My problem is that from 4.5 downward only the runtime is available. Makes me wonder if it's not time to remove explicitly stating 4.0 in the project file.

@ebfortin
Copy link
Contributor Author

Has been merged through PR #978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants