Add B Units #904
Merged
Add B Units #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
=======================================
Coverage 82.69% 82.69%
=======================================
Files 291 291
Lines 44010 44020 +10
=======================================
+ Hits 36393 36403 +10
Misses 7617 7617
Continue to review full report at Codecov.
|
angularsen
requested changes
Feb 22, 2021
UnitsNet.NumberExtensions.Tests/GeneratedCode/NumberToStandardVolumeFlowExtensionsTest.g.cs
Show resolved
Hide resolved
|
Thanks! Nuget on the way |
Fantastic! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"B Unit" is a geotechnical industry term used by a number of companies (Geokon, Geosense, RST Instruments, Sisgeo). B Units = Frequency² / 1000. Whereas the concept is relatively common in the industry, there isn't a consensus in naming.
We chose "B Units", but we're certainly open to other options.
P.S. I don't know why changes to "Standard Volume Flow" showed up in the gen. The only significant changes are "Frequency.json" and "FrequencyTests.cs".