Skip to content

Deprecate MaxValue, MinValue #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Deprecate MaxValue, MinValue #884

merged 2 commits into from
Jan 6, 2021

Conversation

angularsen
Copy link
Owner

@angularsen angularsen commented Dec 30, 2020

See discussion in #848.

There is no good choice for min/max value that don't risk running into overflow exception and the value may change if larger/smaller units are added later.

For range checks, we recommend specifying an application-specific value or using nullability for unbounded upper/lower value.

Changes

  • Mark MinValue and MaxValue as obsolete for all quantities

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #884 (19ee802) into master (6e7ae0e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         287      287           
  Lines       43362    43362           
=======================================
  Hits        35888    35888           
  Misses       7474     7474           
Impacted Files Coverage Δ
...nitsNet/GeneratedCode/Quantities/Acceleration.g.cs 82.56% <ø> (ø)
...et/GeneratedCode/Quantities/AmountOfSubstance.g.cs 82.88% <ø> (ø)
...tsNet/GeneratedCode/Quantities/AmplitudeRatio.g.cs 77.77% <ø> (ø)
UnitsNet/GeneratedCode/Quantities/Angle.g.cs 82.01% <ø> (ø)
...tsNet/GeneratedCode/Quantities/ApparentEnergy.g.cs 77.24% <ø> (ø)
...itsNet/GeneratedCode/Quantities/ApparentPower.g.cs 77.77% <ø> (ø)
UnitsNet/GeneratedCode/Quantities/Area.g.cs 84.46% <ø> (ø)
UnitsNet/GeneratedCode/Quantities/AreaDensity.g.cs 75.00% <ø> (ø)
.../GeneratedCode/Quantities/AreaMomentOfInertia.g.cs 79.42% <ø> (ø)
UnitsNet/GeneratedCode/Quantities/BitRate.g.cs 85.43% <ø> (ø)
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e7ae0e...19ee802. Read the comment docs.

@bitbonk
Copy link

bitbonk commented Jan 6, 2021

LGTM ?

@angularsen
Copy link
Owner Author

Thanks, yes I'll just merge this. It is safe enough to revert if we change our minds later.

@angularsen angularsen merged commit 342377a into master Jan 6, 2021
@angularsen angularsen deleted the deprecate-minmax branch January 6, 2021 09:05
@angularsen
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants