Added kilopound-force imperial variant to force #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks perfect to me! |
luli0401
added a commit
to wgvdn/UnitsNet
that referenced
this pull request
Feb 6, 2020
Added kilopound-force imperial variant to force (angularsen#747)
dschuermans
deleted the
feature/Update-Force-Unit-Add-KilopoundForce-variant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing the imperial variant of kilonewtons, being Kilopound-force.
Up untill now, we've worked around it in our code using an extension method:
So i'm adding it to the library so others can use it too.
Due to the difference in abbreviation (lbf vs kipf), i couldn't simply add the "Kilo" prefix to Kilopound-force (which I initially tried)
Converter used: https://www.unitconverters.net/force/kilopound-force-to-newton.htm