Skip to content

Add VolumePerLength yd3 / ft and ftUS #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions Common/UnitDefinitions/VolumePerLength.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,30 @@
"Abbreviations": [ "bbl/ft" ]
}
]
},
{
"SingularName": "CubicYardPerFoot",
"PluralName": "CubicYardsPerFoot",
"FromUnitToBaseFunc": "x*2.50838208",
"FromBaseToUnitFunc": "x/2.50838208",
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "yd³/ft" ]
}
]
},
{
"SingularName": "CubicYardPerUsSurveyFoot",
"PluralName": "CubicYardsPerUsSurveyFoot",
"FromUnitToBaseFunc": "x*2.50837706323584",
"FromBaseToUnitFunc": "x/2.50837706323584",
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "yd³/ftUS" ]
}
]
}
]
}
4 changes: 4 additions & 0 deletions UnitsNet.Tests/CustomCode/VolumePerLengthTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,9 @@ public class VolumePerLengthTests : VolumePerLengthTestsBase
protected override double LitersPerMeterInOneCubicMeterPerMeter => 1000;

protected override double OilBarrelsPerFootInOneCubicMeterPerMeter => 1.917134088;

protected override double CubicYardsPerFootInOneCubicMeterPerMeter => 0.3986633487670267521605;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to verify these as I could not find any references, but I trust you checked it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick check would be

1 m² = 1.19599 yd²
1.19599 yd² * (1 yd / 3 ft) = 0.3986633 yd³ / ft


protected override double CubicYardsPerUsSurveyFootInOneCubicMeterPerMeter => 0.3986641460953189427984;
}
}
20 changes: 20 additions & 0 deletions UnitsNet.Tests/GeneratedCode/VolumePerLengthTestsBase.g.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 34 additions & 0 deletions UnitsNet/GeneratedCode/Quantities/VolumePerLength.g.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions UnitsNet/GeneratedCode/UnitConverter.g.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions UnitsNet/GeneratedCode/Units/VolumePerLengthUnit.g.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.