Skip to content

add Area cubic yard per foot #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gojanpaolo
Copy link
Contributor

No description provided.

@gojanpaolo gojanpaolo requested a review from angularsen January 10, 2020 04:57
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #733 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   58.56%   58.58%   +0.01%     
==========================================
  Files         171      171              
  Lines       38430    38448      +18     
==========================================
+ Hits        22507    22525      +18     
  Misses      15923    15923
Impacted Files Coverage Δ
UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs 100% <ø> (ø) ⬆️
UnitsNet/GeneratedCode/UnitConverter.g.cs 100% <100%> (ø) ⬆️
UnitsNet/GeneratedCode/Quantities/Area.g.cs 66.22% <100%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69bef4...2087d5b. Read the comment docs.

@angularsen
Copy link
Owner

Huh, is this really a commonly used unit? Although the dimensions match an area, it doesn't quite sound like one. I also can't find any good references on google. Do you have any references?

@gojanpaolo
Copy link
Contributor Author

gojanpaolo commented Jan 10, 2020

@angularsen in our case (dredging), we use it for calculating the amount/volume of soil required to fill up the beach. So given the length of the beach, we can calculate the volume we need to dredge.

The usual term for the unit is "Cubic Yards per Linear Foot".


I found this online which is a similar use case (i.e. filling up something) https://www.cityofsignalhill.org/DocumentCenter/View/1987/PW-Standard-Plans2Street200-242?bidId=

image


Another one: https://docs.lib.purdue.edu/cgi/viewcontent.cgi?article=1001&context=inltappubs

image

@angularsen
Copy link
Owner

I found the beach filling example too. But are you sure it makes senses to add this as a unit to Area quantity?

I think maybe this fits better in https://github.com/angularsen/UnitsNet/blob/master/Common/UnitDefinitions/VolumePerLength.json . Then add the appropriate overloads for multiplication and division to support the calculations you need.

@gojanpaolo
Copy link
Contributor Author

Ah, I didn't know that unit exists, nice catch! Will update PR later. Thanks!

@gojanpaolo gojanpaolo closed this Jan 11, 2020
@gojanpaolo gojanpaolo deleted the add-area-cubic-yard-per-foot branch January 11, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants