Skip to content

Features/rotational stiffness per length unit #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Features/rotational stiffness per length unit #419

merged 1 commit into from
Mar 24, 2018

Conversation

dschuermans
Copy link
Contributor

Added new rotational stiffness per length unit and conversions to units involved (rotational stiffness and length)

@dschuermans
Copy link
Contributor Author

@angularsen - Any idea why it keeps including my previous commits? :/
I updated my master with your master before I began and based my branches of off that...

@angularsen
Copy link
Owner

Same as in #418 (comment)

Rebase or cherry pick to only keep the commits you want on top of the official master branch.

@dschuermans
Copy link
Contributor Author

@angularsen - Thanks, updated the PR :-)

return RotationalStiffnessPerLength.FromNewtonMetersPerRadianPerMeter(rotationalStiffness.NewtonMetersPerRadian / length.Meters);
}

public static Length operator /(RotationalStiffness rotationalStiffness, RotationalStiffnessPerLength rotationalStiffnessPerLength)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could later add RotStiff = RotStiffPerLength * Length and RotStiff = Length * RotStiffPerLength if you find a need for those.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see you already added one of these below :-)

Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are good, but I have some concerns about this quantity and its units and how widely used they are. See comment.

return RotationalStiffnessPerLength.FromNewtonMetersPerRadianPerMeter(rotationalStiffness.NewtonMetersPerRadian / length.Meters);
}

public static Length operator /(RotationalStiffness rotationalStiffness, RotationalStiffnessPerLength rotationalStiffnessPerLength)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see you already added one of these below :-)

"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "N·m/rad/m", "Nm/rad/m" ]
Copy link
Owner

@angularsen angularsen Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dimensionally, this could be simplified to N/rad. I can't find much when googling RotationalStiffnessPerLength or NewtonMeterPerRadianPerMeter. Are you sure these are widely used units?
I'm a bit hesitant to add quantities or units that are not well documented, that are often very specific to certain applications.

Can you provide some links or some arguments for that someone else than you will benefit from adding this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angularsen - All units i need and will be adding in the future are all related to structural engineering.
This particular unit is used when you have a stiffness per length, much like the force per length.
Consider having springs on a surface edge at a certain interval. Instead of having to specify each spring separately in just rotation stiffness, you can specify them in one go using the rotation stiffness per length.
If you want more structural engineering software to use this library, you'll want these units ;)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for the clarification. This absolutely sounds like a widely used domain to me so we can add these, although as discussed in #372 proposal 1, we might want to move such quantities out into a separate nugets at some point - although that design comes with some significant challenges we still need to work out

@angularsen angularsen merged commit 99d5500 into angularsen:master Mar 24, 2018
@angularsen
Copy link
Owner

@dschuermans dschuermans deleted the features/RotationalStiffnessPerLengthUnit branch December 3, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants