Features/pressure mega newton per square meter #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, you need to either rebase on top of Try this: git checkout features/PressureMegaNewtonPerSquareMeter
git rebase --interactive upstream/master
# Remove unwanted commit lines in editor, then hit :x to save and exit from Vim editor
git push --force # Force push needed to rewrite history of your branch (removing commits)As for getting extra changes when running |
|
@angularsen Thanks, i'll do it now and update the PR :) |
angularsen
reviewed
Mar 21, 2018
| "Localization": [ | ||
| { | ||
| "Culture": "en-US", | ||
| "Abbreviations": [ "N/m²" ], | ||
| "AbbreviationsWithPrefixes": [ "kN/m²" ] | ||
| "AbbreviationsWithPrefixes": [ "kN/m²", "MN/m²" ] |
There was a problem hiding this comment.
AbbreviationsWithPrefixes is only needed if prefixing k and M does not work, so for en-US culture it can be removed. I'll remove this in master after merging. Russian still needs to be kept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Mega prefix for NewtonPerSquareMeter in the pressure unit.
Not sure why RotationalStiffnessUnit also has changes, happend after I ran the bat file...