Skip to content

Fix more unit names #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Fix more unit names #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
967c42c
Fix unit names in json
Muximize Jan 5, 2024
86caf93
Generate code
Muximize Jan 5, 2024
8f8405e
Fix tests
Muximize Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Common/UnitDefinitions/Density.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
},
{
"SingularName": "GramPerDeciliter",
"PluralName": "GramsPerDeciLiter",
"PluralName": "GramsPerDeciliter",
"FromUnitToBaseFunc": "{x} / 1e-1",
"FromBaseToUnitFunc": "{x} * 1e-1",
"Prefixes": [ "Pico", "Nano", "Micro", "Milli", "Centi", "Deci" ],
Expand Down
8 changes: 4 additions & 4 deletions Common/UnitDefinitions/ElectricPotentialChangeRate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"Units": [
{
"SingularName": "VoltPerSecond",
"PluralName": "VoltsPerSeconds",
"PluralName": "VoltsPerSecond",
"BaseUnits": {
"L": "Meter",
"M": "Kilogram",
Expand All @@ -30,7 +30,7 @@
},
{
"SingularName": "VoltPerMicrosecond",
"PluralName": "VoltsPerMicroseconds",
"PluralName": "VoltsPerMicrosecond",
"BaseUnits": {
"L": "Meter",
"M": "Kilogram",
Expand All @@ -49,7 +49,7 @@
},
{
"SingularName": "VoltPerMinute",
"PluralName": "VoltsPerMinutes",
"PluralName": "VoltsPerMinute",
"BaseUnits": {
"L": "Meter",
"M": "Kilogram",
Expand All @@ -68,7 +68,7 @@
},
{
"SingularName": "VoltPerHour",
"PluralName": "VoltsPerHours",
"PluralName": "VoltsPerHour",
"BaseUnits": {
"L": "Meter",
"M": "Kilogram",
Expand Down
2 changes: 1 addition & 1 deletion Common/UnitDefinitions/FuelEfficiency.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
},
{
"SingularName": "KilometerPerLiter",
"PluralName": "KilometersPerLiters",
"PluralName": "KilometersPerLiter",
"FromUnitToBaseFunc": "100 / {x}",
"FromBaseToUnitFunc": "100 / {x}",
"Localization": [{
Expand Down
2 changes: 1 addition & 1 deletion Common/UnitDefinitions/Speed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
{
"SingularName": "MeterPerMinute",
"PluralName": "MetersPerMinutes",
"PluralName": "MetersPerMinute",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeez, we had this many errors in plural form? I must have been sloppy in the reviews 😓

Nice to get them corrected though!

"BaseUnits": {
"L": "Meter",
"T": "Minute"
Expand Down
28 changes: 14 additions & 14 deletions UnitsNet.NanoFramework/GeneratedCode/Quantities/Density.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading