Add Mach speed unit #1104
Add Mach speed unit #1104
Conversation
|
@angularsen Hoping you might find some time to have a look at this to see what we can do to remedy the test failure. |
|
Hi yes I hope to get to this in the next few days, just a bit wrapped up in work before the summer holidays. |
|
Just an update, am on a vaction this week and will probably not have time to look before the end of the weekend. |
angularsen
force-pushed
the
add-mach-speed-unit
branch
from
5d3656e to
74f9563
Compare
Test case `{_quantity.Name}_QuantityInfo_ReturnsQuantityInfoDescribingQuantity` failed when adding a new unit in #1104 .
QuantityInfo.Units are ordered lexically, but the test enumerated the enum values that have a different ordering.
angularsen
force-pushed
the
add-mach-speed-unit
branch
from
74f9563 to
c85c5d9
Compare
There was a problem hiding this comment.
Sorry for the delay, work and vacation 🌞
I fixed the test case that you hit, in #1108 , then rebased this PR to bring that fix in.
This is almost ready to merge, just a few minor changes required.
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
======================================
Coverage 85% 85%
======================================
Files 318 318
Lines 48795 48805 +10
======================================
+ Hits 41665 41675 +10
Misses 7130 7130
Continue to review full report at Codecov.
|
angularsen
changed the title
|
Thanks! The nuget should be out in an hour or so. The builds are a bit slow these days. |
Hello @angularsen. Thanks for the help...github is a bit different. Note, these changes generate the testing error I described in the discussions about the two lists of enumerations not being identical since the order of the entries are different from one another. I'm also curious why the generated enum is 42 when it seems like it should have chosen 33?