This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(test): fix #1069, FakeDate should handle constructor parameter #1070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1069.
fix #1071.
in
fakeAsync
, nowDate
is monkey-patched withFakeDate
,FakeDate
should handle parameters in constructor correctly, such asnew Date(1995, 1)
,new Date(0)
.should handle
Date.UTC()
infakeAsync
correctlyshould handle
Date.parse()
infakeAsync
correctly@mhevery , sorry this is a regression bug, please review and please check should we cut a new release or not.