This repository was archived by the owner on Nov 21, 2025. It is now read-only.
fix: log all console output to file #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently ask users to submit two logs when submitting a new issue: 1. Logs from file, and 2. Logs from output channel (see screenshot below). In order to simplify the workflow, we should log all console output to file as well. This has two advantages: 1. We can piece together a more coherent picture by just looking at the log file. 2. Users no longer have to submit logs from output channel.
ayazhafiz
approved these changes
Nov 7, 2020
Contributor
ayazhafiz
left a comment
ayazhafiz
left a comment
There was a problem hiding this comment.
After the next release is cut we should update the issue template to ask only for the log file.
kyliau
added a commit
to kyliau/vscode-ng-language-service
that referenced
this pull request
Nov 9, 2020
This is a follow-up to angular#962 We should always call `Session.info()` or `Session.error()` to log entries so that console entries also show up in log file.
kyliau
added a commit
to kyliau/vscode-ng-language-service
that referenced
this pull request
Nov 9, 2020
This is a follow-up to angular#962 We should always call `Session.info()` or `Session.error()` to log entries so that console entries also show up in log file.
kyliau
added a commit
to kyliau/vscode-ng-language-service
that referenced
this pull request
Nov 9, 2020
This is a follow-up to angular#962 We should always call `Session.info()` or `Session.error()` to log entries so that console entries also show up in log file.
ayazhafiz
pushed a commit
that referenced
this pull request
Nov 9, 2020
This is a follow-up to #962 We should always call `Session.info()` or `Session.error()` to log entries so that console entries also show up in log file.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently ask users to submit two logs when opening a new issue:
In order to simplify the workflow, we should log all console output to file
as well. This has two advantages:
file.
Additional context: when debugging the integration test, I personally found it difficult to get a full understanding by just looking at the log file.