Skip to content

Conversation

@alomardev
Copy link

Description

This PR fixes an issue where the Angular Language Service extension does not recognize @angular/core when its declaration file is located at @angular/core/types/core.d.ts.

Problem

The extension only checked for Angular core at these two paths:

  • @angular/core/core.d.ts
  • @angular/core/index.d.ts

When Angular core is at @angular/core/types/core.d.ts, the extension fails to detect it and does not initialize the language service.

Solution

Added @angular/core/types/core.d.ts to the list of checked paths in the isExternalAngularCore(...) function.

@google-cla
Copy link

google-cla bot commented Oct 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alan-agius4
Copy link
Collaborator

This has been addressed in extension version 20.3.3

@alan-agius4 alan-agius4 closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants